feat: add endpoint to fetch open DEX offers for an account #291 - #417
Merged
Mystery-CLI merged 1 commit intoApr 26, 2026
Merged
Conversation
|
@Dami24-hub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a new API endpoint that retrieves a list of open decentralized exchange (DEX) offers for a given Stellar account. This is a critical building block for the upcoming order management UI, allowing users to view and track their active limit orders.
Changes:
New Route: Added GET /api/accounts/:address/offers.
Horizon Integration: Implemented a service layer call to Stellar Horizon to fetch account-specific offers.
Data Formatting: Standardized the offer objects for easier frontend consumption, including asset identifiers and price ratios.
Validation: Added middleware to validate the public key format before processing the request.
Technical Highlights:
Efficiency: Leverages the Stellar SDK's built-in pagination support for future-proofing large offer sets.
Observability: Integrated with the project's structured logging system for request/response tracking.
Safety: Sanity checks on the account address prevent unnecessary Horizon API hits.
Checklist:
[x] Branch feature/fetch-dex-offers-291 created and pushed.
[x] Validated with live Testnet/Mainnet account data.
[x] Error handling covers invalid addresses and network timeouts.
[x] All tests and linting pass.
[x] Linked to Issue #291.
closes #291